On Tue, 5 May 2026 11:22:39 GMT, Kevin Walls <[email protected]> wrote:

>> src/jdk.jconsole/share/classes/sun/tools/jconsole/inspector/XMBeanAttributes.java
>>  line 823:
>> 
>>> 821:                                                      int column) {
>>> 822: 
>>> 823:             table.putClientProperty("html.disable", Boolean.TRUE);
>> 
>> we do not put html.disable property on JTable object directly as JTable 
>> object doesn't use label directly, where html tags would be used, but via 
>> cell renderer...We put it on DefaultTableCellRenderer which extends JLabel 
>> so I guess better would be to put it on l833 for MaximizedCellRenderer 
>> object provided it extends DTCR
>
> OK thanks, I can remove this line.  XMBeanAttributes extends XTable and 
> XTable.java has a getCellRenderer() call that does the disable.
> Will add in MaximizedCellRenderer as well.

Shouldn't the value of `html.disable` property propagate from `JTable` to its 
cell renderer? It looks reasonable. One shouldn't need to override methods that 
return cell renderer to disable HTML.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30998#discussion_r3188020216

Reply via email to