On Tue, 5 May 2026 11:33:26 GMT, Kevin Walls <[email protected]> wrote:
>> JConsole needs to disable HTML rendering in components populated by MBeans, >> as is standard practice. >> >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Kevin Walls has updated the pull request incrementally with one additional > commit since the last revision: > > remove one unnecessary html.disable, add one more Marked as reviewed by aivanov (Reviewer). src/jdk.jconsole/share/classes/sun/tools/jconsole/inspector/XMBeanAttributes.java line 833: > 831: MaximizedCellRenderer zr = > 832: (MaximizedCellRenderer) cell.getRenderer(); > 833: return zr.getComponent(); Very unlikely, but still a possibility: the second call to `cell.getRenderer()` inside the body of `if` may return a cell renderer that's not an instance of `MaximizedCellRenderer`. src/jdk.jconsole/share/classes/sun/tools/jconsole/inspector/XMBeanNotifications.java line 105: > 103: t.putClientProperty("html.disable", Boolean.TRUE); > 104: return t; > 105: } This should happen automatically… The value of `html.disable` should propagate from the component to the associated tooltip. We should submit a bug for JDK if there's none existing yet. ------------- PR Review: https://git.openjdk.org/jdk/pull/30998#pullrequestreview-4227504420 PR Review Comment: https://git.openjdk.org/jdk/pull/30998#discussion_r3188054791 PR Review Comment: https://git.openjdk.org/jdk/pull/30998#discussion_r3188072539
