On Sat, 2 May 2026 10:42:30 GMT, Yasumasa Suenaga <[email protected]> wrote:
>> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Guard TRUE definition > > src/jdk.attach/share/native/librevival_support/revival_support.c line 34: > >> 32: >> 33: #define TRUE 1 >> 34: #define FALSE 0 > > `TRUE` and `FALSE` are defined on Windows by default. So it might be better > as following: > > Suggestion: > > #ifndef TRUE > #define TRUE 1 > #endif > > #ifndef FALSE > #define FALSE 0 > #endif Yes will do. This revival_support library is currently only build on Linux but could be useful on other platforms. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31011#discussion_r3208057049
