On Sat, 2 May 2026 09:44:00 GMT, Yasumasa Suenaga <[email protected]> wrote:
>> Kevin Walls has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Use accessor to access _mutex >> - remove revival 'status' field > > src/hotspot/share/runtime/thread.cpp line 649: > >> 647: rdata->version = REVIVAL_VERSION; >> 648: rdata->size_this = sizeof(vm_revival_data); >> 649: rdata->status = 1; > > What does "1" mean in this case? I think it is better to be `enum` if > possible. Thanks, I will remove that field. I was thinking that it could show progression through the revival steps, but that does not seem to be needed. If things went badly wrong, this method will return nullptr when Thread::current_or_null() fails. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31011#discussion_r3228261818
