On Fri, 8 May 2026 13:30:52 GMT, Alan Bateman <[email protected]> wrote:
>> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >> only use _s_vm_release_global, no need to use mangled version on Linux > > src/jdk.attach/share/classes/com/sun/tools/attach/VirtualMachine.java line > 235: > >> 233: * >> 234: * @param env >> 235: * A Map of provider-specific settings to configure the >> attach. > > Add ", can be empty". With `newFileSystem` and other APIs we use "provider specific properties" rather than "provider specific settings". > src/jdk.attach/share/classes/com/sun/tools/attach/spi/AttachProvider.java > line 175: > >> 173: * @since 27 >> 174: */ >> 175: public VirtualMachine attachVirtualMachine(String id, Map<String, >> ?> env) > > This will meed an `@implSpec` to say that the default implementation throws > UOE. Do you agree that `provider.attachVirtualMachine(id, Map.of())` and `provider.attachVirtualMachine(id)` should be equivalent? (This goes to the question as to whether an empty map should invoke the 1-arg method rather than throw UOE) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31011#discussion_r3208984988 PR Review Comment: https://git.openjdk.org/jdk/pull/31011#discussion_r3208948584
