On Fri, 8 May 2026 13:36:51 GMT, Alan Bateman <[email protected]> wrote:
>> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >> only use _s_vm_release_global, no need to use mangled version on Linux > > src/jdk.attach/share/classes/com/sun/tools/attach/VirtualMachine.java line > 279: > >> 277: * >> 278: * @since 27 >> 279: */ > > Are you missing the `@throws` for the 2 checked exceptions, I can't see them > in the changes. > > I suspect that this method will also need to specify IllegalArgumentException > for bad values. I need to dig deeper to understand other exception cases, > why if revivalCachePath specify a directory that does not exist. Adding AttachNotSupportedException and IOException, thanks. Specifying a bad revivalCachePath is a fatal error which we find later in the native code, so the execute operation fails: ```$ build/linux-x64/images/jdk/bin/jcmd -R /not/a/directory core.265920 VM.version core.265920: revival: cannot create directory '/not/a/directory/core.265920.revival': use -R to specify usable location for cache directory. I suppose this could be made to throw an Exception in Java in VirtualMachineCoreDumpImpl.java. Specifying bad library directories is fine, we just try them and they can't be used. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31011#discussion_r3209503086
