On Thu, 30 Jul 2026 12:29:47 GMT, Coleen Phillimore <[email protected]> wrote:

>> src/hotspot/share/services/threadService.cpp line 1054:
>> 
>>> 1052:         continue;
>>> 1053:       }
>>> 1054:       st->print_cr("%s \"%s\"", owner_desc, currentThread->name());
>> 
>> I was puzzled why you moved and duplicated this, but if I am reading things 
>> correctly the old code would cause two similar print outs for the raw 
>> monitor case.
>
> The line followed the if {} else {} statement because both printed that line, 
> so I had to copy it because the raw monitor-only case did not want to copy 
> it.  It came out looking like this:
> 
>     Found one Java-level deadlock:
>     =============================
>     "Thread-1":
>       waiting to lock JVM TI raw monitor 0x00007fda347cb460,
>       which is held by "Thread-2"
>     ,
>       which is held by "Thread-2"

We could move this under an `else` branch and remove the `continue` above.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32092#discussion_r3685387793

Reply via email to