On Mon, 24 Aug 2026 22:25:59 GMT, Serguei Spitsyn <[email protected]> wrote:
>> Chris Plummer has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - clean up comment
>> - fix missing failure result
>
> test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/stop/stop002.java line
> 70:
>
>> 68: static final String DEBUGGEE_STOP_LOOP2_FIELD = "stopLooping2";
>> 69: // debuggee field used to indicate that debugger got
>> OpaqueFrameException
>> 70: static final String DEBUGGEE_GOT_OPE_FIELD =
>> "gotOpaqueFrameException";
>
> Nit: Why `DEBUGGEE_GOT_OPE_FIELD` ? Should it be `DEBUGGEE_GOT_OFE_FIELD` ?
> It is kind of confusing.
Fixed.
> test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/stop/stop002.java line
> 239:
>
>> 237: } else {
>> 238: ofe.printStackTrace();
>> 239: log.complain("TEST #4 FAILED: caught unexpected " +
>> ofe);
>
> Nit: Should this message also say the `OFE` is not expected in the
> `vthreadMode` ?
Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32403#discussion_r3848577874
PR Review Comment: https://git.openjdk.org/jdk/pull/32403#discussion_r3848578815
