On Tue, 10 Nov 2026 21:58:28 GMT, Leonid Mesnik <[email protected]> wrote:
>> Shiv Shah has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Drop the virtual argument, the frame count already tells > > test/hotspot/jtreg/serviceability/AsyncGetCallTrace/MyPackage/ASGCTBaseTest.java > line 29: > >> 27: /** >> 28: * @test >> 29: * @summary Verifies that AsyncGetCallTrace is call-able and provides >> sane information on platform and virtual threads. > > It is needed to split test and add > @requires vm.continuations > to the testcase with virtual threads. > > Also, add > @requires test.thread.factory == null > to both test cases. > No need to run any of them on the main virtual thread. Done. Split into a platform and a virtual case. The virtual one has @requires vm.continuations, both have @requires test.thread.factory == null. ProblemList-Xcomp now lists both ids, the old line did not match them. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33617#discussion_r4569989361
