On Fri, 13 Nov 2026 23:54:06 GMT, Shiv Shah <[email protected]> wrote:
>> With the virtual test thread factory main runs on a virtual thread. >> AsyncGetCallTrace walks on into the carrier frames there. GetStackTrace >> stops at the continuation entry. The test expects the same frames from both >> and fails. >> >> Test only change. The test is now two cases, platform and virtual, each >> starts its own thread. A longer AsyncGetCallTrace trace is accepted only >> when the frame right after the GetStackTrace ones is >> Continuation.enterSpecial. The virtual case requires vm.continuations. >> Neither case runs with a test thread factory, the ProblemList-Virtual entry >> is removed. ProblemList-Xcomp lists both ids. >> >> --- >> Testing: >> - [x] Both cases 5 times on linux-x64 and linux-aarch64 debug, the same with >> -XX:-VMContinuations (only the platform case runs), serviceability with the >> virtual thread factory, and tier1-3 on those two platforms. >> >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Shiv Shah has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains four additional commits since > the last revision: > > - Split into a platform and a virtual test case > - Merge remote-tracking branch 'upstream/master' into JDK-8308026 > - Drop the virtual argument, the frame count already tells > - 8308026: AsyncGetCallTraceTest fails with virtual threads Changes requested by lmesnik (Reviewer). test/hotspot/jtreg/serviceability/AsyncGetCallTrace/MyPackage/ASGCTBaseTest.java line 40: > 38: /** > 39: * @test id=virtual > 40: * @summary Verifies that AsyncGetCallTrace is call-able and provides > sane information. Second summary is not needed. test/hotspot/jtreg/serviceability/AsyncGetCallTrace/MyPackage/ASGCTBaseTest.java line 41: > 39: * @test id=virtual > 40: * @summary Verifies that AsyncGetCallTrace is call-able and provides > sane information. > 41: * @compile ASGCTBaseTest.java i think this line is not needed in both tests. ------------- PR Review: https://git.openjdk.org/jdk/pull/33617#pullrequestreview-5899727651 PR Review Comment: https://git.openjdk.org/jdk/pull/33617#discussion_r4570007549 PR Review Comment: https://git.openjdk.org/jdk/pull/33617#discussion_r4570007727
