Hi Yrineu, Although TCP Flags related yang models are present in the openflowplugin, but there was no provider implementation existed in openflowplugin, so i doubt there will be any regression for this feature. We added this implementation because NetVirt project needed the support of TCP Flags to implement one of their functionality.
In NIC project once you merge this patch, your build should come back to normal. https://git.opendaylight.org/gerrit/#/c/43077/ Infact your build is fine, it's that distribution check is failing on this patch and that's the reason jenkins did -1 on this patch. Distribution failure is happening because of some other patch got merged in odlparent repository. Following thread has more details about that failure. https://lists.opendaylight.org/pipermail/release/2016-August/007610.html Thanks Anil On Wed, Aug 3, 2016 at 9:12 PM, Yrineu Rodrigues <yfrfel...@gmail.com> wrote: > Hi Anil, > > Just a quickly question: We have some project or some merged feature on > Openflow Plugin using the 'Ext109 openflow tcp flag' right now? It's > possible to do a revert and waits for the end of this release to generate a > new version containing this changes? Could avoid some regressions! > > Please, let me know if makes sense. > > Thanks, > > > On Wed, Aug 3, 2016 at 8:11 PM, Anil Vishnoi <vishnoia...@gmail.com> > wrote: > >> Hi Yrineu, >> >> Please reach out to me, if you face any issue because of this patch. >> >> Thanks >> Anil >> >> On Wed, Aug 3, 2016 at 3:08 PM, Yrineu Rodrigues <yfrfel...@gmail.com> >> wrote: >> >>> This does not causes big impacts on NIC project, but I'm looking to >>> ensure that all tests will work properly after merge it. >>> >>> Thanks, >>> >>> On Wed, Aug 3, 2016 at 6:47 PM, Anil Vishnoi <vishnoia...@gmail.com> >>> wrote: >>> >>>> No, it's not how it is supposed to work. >>>> >>>> Existing tcp_flag api's in openflowplugin had no implementation in >>>> openflowplugin project ( although there are models defined for it in >>>> plugin), so i was under impression that no project should be using it, >>>> because it's not going to work for them. Probably i should have check'ed it >>>> rather than assuming it. So under that assumption, i thought we don't >>>> really need a waiver for this change. >>>> >>>> Given that TCP Flags is now approved ONF extension for OpenFlow 1.3, I >>>> added the support for the API's. OpenFlowplugin patch that I pushed was >>>> dependent on the OpenFlow java patch. Michal reviewed and merged >>>> openflowjava patch, so i merged the openflowplugin patch as well, otherwise >>>> openflowplugin build is going to break. That will eventual break all the >>>> dependent projects as well. >>>> >>>> I merged my own patch, because there was no committer available to >>>> review this patch at 2 AM PST, so rather than putting projects on the risk >>>> of build failure, I merged it. This is something which we have done in the >>>> past as well to avoid similar situations. >>>> >>>> I don't see groupbasedpolicy project is impacted by this change. Verify >>>> build of groupbasedpolicy is fine (#7, #8 were triggered after the >>>> openflowplugin patch merge) >>>> >>>> >>>> https://jenkins.opendaylight.org/releng/view/groupbasedpolicy/job/groupbasedpolicy-verify-boron-mvn33-openjdk8/ >>>> >>>> Hope it answer some of your questions. >>>> >>>> Thanks >>>> Anil >>>> >>>> On Wed, Aug 3, 2016 at 2:10 PM, Brady Allen Johnson < >>>> brady.allen.john...@ericsson.com> wrote: >>>> >>>>> >>>>> There is something I dont understand here: You're looking for an >>>>> agreement, but you authored the patch, and you merged it yourself. We >>>>> didnt >>>>> get any chance to agree or disagree. >>>>> >>>>> Is this how API Freeze Waivers are supposed to work? >>>>> >>>>> BTW, Im adding GBP, since they are affected too. >>>>> >>>>> Brady >>>>> >>>>> On 03/08/16 22:43, Anil Vishnoi wrote: >>>>> >>>>> + release >>>>> >>>>> On Wed, Aug 3, 2016 at 1:40 PM, Anil Vishnoi <vishnoia...@gmail.com> >>>>> wrote: >>>>> >>>>>> Note: This email is to seek agreement on a waiver of API FREEZE. >>>>>> >>>>>> The patch for wich a waiver of API FREEZE is being sought is: >>>>>> >>>>>> https://git.opendaylight.org/gerrit/42630 >>>>>> >>>>>> and it is contributed to: >>>>>> OpenFlow Plugin project >>>>>> >>>>>> The following projects have been determined to be impacted: >>>>>> >>>>>> genius Consumer >>>>>> netvirt Consumer >>>>>> vtn Consumer >>>>>> nic Consumer >>>>>> sfc Consumer >>>>>> didm Consumer >>>>>> >>>>>> Agreement to waive API FREEZE for >>>>>> https://git.opendaylight.org/gerrit/42630 >>>>>> >>>>>> will be indicated by +1 from each project representative on the >>>>>> Gerrit itself. >>>>>> >>>>>> There is no agreement to waive API FREEZE until all project >>>>>> representatives have +1ed the Gerrit. >>>>>> >>>>>> This email is *only* about waiving of API FREEZE, normal code review >>>>>> will proceed in the normal fashion >>>>>> >>>>>> ----------------------------- >>>>>> This patch is already merged and respective fixes are pushed to the >>>>>> impacted projects: >>>>>> >>>>>> genius : https://git.opendaylight.org/gerrit/43047 (merged) >>>>>> netvirt https://git.opendaylight.org/gerrit/43049 (merged) >>>>>> vtn https://git.opendaylight.org/gerrit/43038 (merged) >>>>>> nic https://git.opendaylight.org/gerrit/43077 (waiting for review) >>>>>> sfc https://git.opendaylight.org/gerrit/43082 (waiting for review) >>>>>> didm https://git.opendaylight.org/gerrit/43086 (waiting for review) >>>>>> Thanks >>>>>> Anil >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Thanks >>>>> Anil >>>>> >>>>> >>>>> _______________________________________________ >>>>> TSC mailing >>>>> listTSC@lists.opendaylight.orghttps://lists.opendaylight.org/mailman/listinfo/tsc >>>>> >>>>> >>>>> >>>> >>>> >>>> -- >>>> Thanks >>>> Anil >>>> >>>> _______________________________________________ >>>> nic-dev mailing list >>>> nic-...@lists.opendaylight.org >>>> https://lists.opendaylight.org/mailman/listinfo/nic-dev >>>> >>>> >>> >>> >>> -- >>> *Yrineu Rodrigues* >>> *OpendayLight NIC PTL/committer* >>> -- >>> >>> *Linkedin <http://www.linkedin.com/in/yrineu>* >>> *NIC wiki page* >>> <https://wiki.opendaylight.org/view/Network_Intent_Composition:Main> >>> >>> >> >> >> -- >> Thanks >> Anil >> > > > > -- > *Yrineu Rodrigues* > *OpendayLight NIC PTL/committer* > -- > > *Linkedin <http://www.linkedin.com/in/yrineu>* > *NIC wiki page* > <https://wiki.opendaylight.org/view/Network_Intent_Composition:Main> > > -- Thanks Anil
_______________________________________________ sfc-dev mailing list sfc-dev@lists.opendaylight.org https://lists.opendaylight.org/mailman/listinfo/sfc-dev
