> I don't see groupbasedpolicy project is impacted by this change. Verify build > of groupbasedpolicy is fine (#7, #8 were triggered after the openflowplugin > patch merge)
Not true! Actually #7, #8 are verify and merge jobs for the fix [1]. #6 [2] is affected and failed one. So please don‘t forget on GBP in next changes. [1] https://git.opendaylight.org/gerrit/#/c/43056/ [2] https://jenkins.opendaylight.org/releng/view/groupbasedpolicy/job/groupbasedpolicy-verify-boron-mvn33-openjdk8/6/ Regards, Matej From: Anil Vishnoi [mailto:vishnoia...@gmail.com] Sent: Wednesday, August 03, 2016 11:47 PM To: Brady Allen Johnson <brady.allen.john...@ericsson.com> Cc: sfc-dev@lists.opendaylight.org; <t...@lists.opendaylight.org> <t...@lists.opendaylight.org>; groupbasedpolicy-...@lists.opendaylight.org; rele...@lists.opendaylight.org; nic-...@lists.opendaylight.org; didm-...@lists.opendaylight.org Subject: Re: [groupbasedpolicy-dev] [OpenDaylight TSC] [SEEK AGREEMENT ON API FREEZE WAIVER] Openflow plugin TCP Flags API change No, it's not how it is supposed to work. Existing tcp_flag api's in openflowplugin had no implementation in openflowplugin project ( although there are models defined for it in plugin), so i was under impression that no project should be using it, because it's not going to work for them. Probably i should have check'ed it rather than assuming it. So under that assumption, i thought we don't really need a waiver for this change. Given that TCP Flags is now approved ONF extension for OpenFlow 1.3, I added the support for the API's. OpenFlowplugin patch that I pushed was dependent on the OpenFlow java patch. Michal reviewed and merged openflowjava patch, so i merged the openflowplugin patch as well, otherwise openflowplugin build is going to break. That will eventual break all the dependent projects as well. I merged my own patch, because there was no committer available to review this patch at 2 AM PST, so rather than putting projects on the risk of build failure, I merged it. This is something which we have done in the past as well to avoid similar situations. I don't see groupbasedpolicy project is impacted by this change. Verify build of groupbasedpolicy is fine (#7, #8 were triggered after the openflowplugin patch merge) https://jenkins.opendaylight.org/releng/view/groupbasedpolicy/job/groupbasedpolicy-verify-boron-mvn33-openjdk8/ Hope it answer some of your questions. Thanks Anil On Wed, Aug 3, 2016 at 2:10 PM, Brady Allen Johnson <brady.allen.john...@ericsson.com<mailto:brady.allen.john...@ericsson.com>> wrote: There is something I dont understand here: You're looking for an agreement, but you authored the patch, and you merged it yourself. We didnt get any chance to agree or disagree. Is this how API Freeze Waivers are supposed to work? BTW, Im adding GBP, since they are affected too. Brady On 03/08/16 22:43, Anil Vishnoi wrote: + release On Wed, Aug 3, 2016 at 1:40 PM, Anil Vishnoi <vishnoia...@gmail.com<mailto:vishnoia...@gmail.com>> wrote: Note: This email is to seek agreement on a waiver of API FREEZE. The patch for wich a waiver of API FREEZE is being sought is: https://git.opendaylight.org/gerrit/42630 and it is contributed to: OpenFlow Plugin project The following projects have been determined to be impacted: genius Consumer netvirt Consumer vtn Consumer nic Consumer sfc Consumer didm Consumer Agreement to waive API FREEZE for https://git.opendaylight.org/gerrit/42630 will be indicated by +1 from each project representative on the Gerrit itself. There is no agreement to waive API FREEZE until all project representatives have +1ed the Gerrit. This email is *only* about waiving of API FREEZE, normal code review will proceed in the normal fashion ----------------------------- This patch is already merged and respective fixes are pushed to the impacted projects: genius : https://git.opendaylight.org/gerrit/43047 (merged) netvirt https://git.opendaylight.org/gerrit/43049 (merged) vtn https://git.opendaylight.org/gerrit/43038 (merged) nic https://git.opendaylight.org/gerrit/43077 (waiting for review) sfc https://git.opendaylight.org/gerrit/43082 (waiting for review) didm https://git.opendaylight.org/gerrit/43086 (waiting for review) Thanks Anil -- Thanks Anil _______________________________________________ TSC mailing list t...@lists.opendaylight.org<mailto:t...@lists.opendaylight.org> https://lists.opendaylight.org/mailman/listinfo/tsc -- Thanks Anil MatejPerina Software Developer Sídlo / Mlynské Nivy 56 / 821 05 Bratislava / Slovakia R&D centrum / Bôrická cesta 107 / 010 01 Žilina / Slovakia +421 911 016 197 / matej.per...@pantheon.tech reception: +421 2 212 93 331 / www.pantheon.sk [logo]
_______________________________________________ sfc-dev mailing list sfc-dev@lists.opendaylight.org https://lists.opendaylight.org/mailman/listinfo/sfc-dev
