Hi Vladimir, General comments - Can you tidy up the CDDL headers of all the files that have them. Examples for various types of file are here: http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/prototypes/
usr/src/cmd/unrar/METADATA - You are missing several fields. See the METADATA section of http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines usr/src/cmd/unrar/Makefile.sfw - You could use $(COMPONENT_NAME):sh to set $(VER) - Use $(GMAKE) instead of /usr/gnu/bin/make. Let the workspace decide where to find GNU make - use 'env -' and not 'env' in 'env $(TARGET_ENV) \' it'll prevent GNU make picking up any unwanted ENV VARS - Use $(SHELL) instead of $(SH) when calling install-unrar (see below regarding use of ksh93) usr/src/cmd/unrar/unrar.1 - The man page is a modified version of the unrar man page, but the original version isn't included with the source bundle right? Does the original include the license information at the end as well? (the rarlab website just broke so I can't check). I think what you've done is ok, maybe others might comment. usr/src/pkgdefs/SUNWunrar/depend - You don't need to include this in your workspace, in your Makefile you have DATAFILES= depend and that will copy in the standard workspace depend file during the build usr/src/cmd/unrar/install-unrar - Use ksh93 instead of sh. The following describes the 3 things you need to do: > use /usr/bin/ksh93 or /usr/bin/bash for install-sfw* > and add a $ set -o errexit # at the beginning and > replace ". ${SRC}/tools/install.subr" with > "source ${SRC}/tools/install.subr" (the idea is to > catch failures in the script and abort it at that > point, right now the script will just continue) usr/src/cmd/unrar/sunman-stability - Change 'expect' to 'unrar' in "Source for expect is available on http://opensolaris.org.\"; Amanda Vladimir Marek wrote: > Hi, > > I would like to ask you for review of > > http://cr.opensolaris.org/~neuron/unrar/ > > It's my first, so expect unexpected :) Arc case is here: > > http://arc.opensolaris.org/caselog/PSARC/2008/756/ > > Thank you > > > ------------------------------------------------------------------------ > > _______________________________________________ > sfwnv-discuss mailing list > sfwnv-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss >
