Hi Amanda, Thank you for your generous comments.
> - Can you tidy up the CDDL headers of all the files that have them. > Examples for various types of file are here: > http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/prototypes/ I found one bad year, and one expanded SCCS keywords. Am I missing something else ? > usr/src/cmd/unrar/METADATA > - You are missing several fields. See the METADATA section of > http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines Ah, that's page I started long time ago :) I'm glad it works ! > usr/src/cmd/unrar/Makefile.sfw > - You could use $(COMPONENT_NAME):sh to set $(VER) I used $(PROJECT) instead, so that shell does not have to be spawned twice > - Use $(GMAKE) instead of /usr/gnu/bin/make. Let the workspace decide > where to find GNU make > - use 'env -' and not 'env' in 'env $(TARGET_ENV) \' it'll prevent GNU > make picking up any unwanted ENV VARS > - Use $(SHELL) instead of $(SH) when calling install-unrar (see below > regarding use of ksh93) done > usr/src/cmd/unrar/unrar.1 > - The man page is a modified version of the unrar man page, but the > original version isn't included with the source bundle right? Yes. unrar does not have man page. I created one (Linux has man page, but it's not up to Solaris standards really) and offered it to unrar authors. The man page probably will be in next unrar release. > Does the original include the license information at the end as well? > (the rarlab website just broke so I can't check). I think what you've > done is ok, maybe others might comment. At the moment there is no official man page, but in future mine might become one. > usr/src/pkgdefs/SUNWunrar/depend > - You don't need to include this in your workspace, in your Makefile you > have DATAFILES= depend and that will copy in the standard workspace > depend file during the build Ah, right > usr/src/cmd/unrar/install-unrar > - Use ksh93 instead of sh. The following describes the 3 things you need > to do: > > > use /usr/bin/ksh93 or /usr/bin/bash for install-sfw* > > and add a $ set -o errexit # at the beginning and > > replace ". ${SRC}/tools/install.subr" with > > "source ${SRC}/tools/install.subr" (the idea is to > > catch failures in the script and abort it at that > > point, right now the script will just continue) Done > usr/src/cmd/unrar/sunman-stability > - Change 'expect' to 'unrar' in "Source for expect is available on > http://opensolaris.org.\"; Uh,oh :) Done Fixed webrev is again at http://cr.opensolaris.org/~neuron/unrar Thank you -- Vlad -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 193 bytes Desc: not available URL: <http://mail.opensolaris.org/pipermail/sfwnv-discuss/attachments/20090402/6630f82c/attachment.bin>
