Hi Paul, I think the folder is full and we are not able to any operation on http://cr.opensolaris.org. Moving to trash is also not working for us. Could you pl. let me know whom do I need to send mail regarding the requirement of free space.
Up till now we have uploaded 5 webrev's and below are the links for the same. http://cr.opensolaris.org/~vivekrt/6816378-mvel http://cr.opensolaris.org/~vivekrt/6816382-jettison http://cr.opensolaris.org/~vivekrt/6816384-jodatime http://cr.opensolaris.org/~vivekrt/6816392-jaxen-core http://cr.opensolaris.org/~vivekrt/6816393-janino The webrev's we need to move to trash are http://cr.opensolaris.org/~vivekrt/Drools-B1 & http://cr.opensolaris.org/~vivekrt/6816397-antlr277/ Can you pl. help us. Thanks in advance, ~Vivek R. Titarmare -----Original Message----- From: Paul Cunningham [mailto:[email protected]] Sent: Thursday, April 02, 2009 3:41 PM To: Vivek Titarmare Subject: Re: [sfwnv-discuss] Request code review for "janino", "jettison", "jaxen-core", "jodatime", "mvel", "relaxngDatatype", "staxapi" & "xpp3min" Vivek Titarmare wrote: > Thanks Paul, > > Even if I separate out index.html page, the pdf would remain a single on. > It's ok to me for changing the active list and creating webrev separately, > this should not take much time. yes fine (if that is easier) > > And the answer to your previous question is yes, the collections of > components make up "Drools". thanks paul > > Thanks, > ~Vivek R. Titarmare > > > -----Original Message----- > From: Paul Cunningham [mailto:paul.cunningham at tadpole.com] > Sent: Thursday, April 02, 2009 3:27 PM > To: Vivek Titarmare > Subject: Re: [sfwnv-discuss] Request code review for "janino", "jettison", > "jaxen-core", "jodatime", "mvel", "relaxngDatatype", "staxapi" & "xpp3min" > > > > Vivek Titarmare wrote: >> Hi Paul, >> >> Since all the packages are in the same workspace and for each package, >> editing pkgdef/Makefile, lib/Makefile and TargetDir files would create lot >> of versions. Is it ok to keep those files as it is and only change the >> active list to create webrev for all the packages? > > That sounds okay to me. Or if you want you could just copy and edit the > current webrev index.html page and create a page with just bits for each > component in it, ie. janino.html, etc. > > sorry to make you extra work > paul > >> >> -----Original Message----- >> From: Paul Cunningham [mailto:paul.cunningham at tadpole.com] >> Sent: Thursday, April 02, 2009 12:52 PM >> To: Vivek Titarmare >> Cc: sfwnv-discuss at opensolaris.org >> Subject: Re: [sfwnv-discuss] Request code review for "janino", "jettison", >> "jaxen-core", "jodatime", "mvel", "relaxngDatatype", "staxapi" & "xpp3min" >> >> Hi Vivek, >> >> I started to look at this but there is too much of it to do in one or >> even two goes, so please could you split the webrev up into its eight (I >> think) component parts and send them out separately (it doesn't look as >> though they need to be done in one go to me). >> >> Below are a couple of points you might want to consider ... >> >> Also I assume this collection of components that make up 'Drools' is >> this application "http://en.wikipedia.org/wiki/Drools"; ? >> >> Paul >> >> Vivek Titarmare wrote: >>> I have posted a webrev for packages "janino", "jettison", "jaxen-core", >>> "jodatime", "mvel", "relaxngDatatype", "staxapi" & "xpp3min" which I am >>> porting to OpenSolaris and would like to request a code review. >>> >>> Please see http://cr.opensolaris.org/~vivekrt/Drools-B1/ and provide any >>> comments as needed if there are any issues which I need to correct. >> >> 1. METADATA >> You have ... >> BUGTRAQ: solaris/utility/drools >> wouldn't it be better if each component part had >> its own category, eg .. >> BUGTRAQ: solaris/utility/janino >> or if you can have this maybe .. >> BUGTRAQ: solaris/utility/drools/janino >> >> 2. install-sfw >> In the install-sfw scripts I looked at you have the >> pkg name and its version hardcoded in the scripts, >> it might be better if you pass this in from the >> Makefile.sfw as an env variable (or option), eg. in >> janino change ... >> janino/Makefile.sfw >> 43 VERS=$(VER) $(SHELL) ./install-sfw >> janino/install-sfw >> 66 cd ${VERS}/dist >> 69 _install N ${VERS}.jar ${JARDIR}/${VERS}.jar 444 >> etc. >> You will then not have to keep changing them every time >> the pkg version is updated. >> >> 3. Drools top level >> How are all the component pkgs pulled together to >> ensure anyone who wants to install Drools has all the >> component parts installed? >> >
