I missed something, see below .. paul
Paul Cunningham wrote: > Vivek, > > Starting at 6816393-janino, this looks okay to me except for my previous > global comments (see below) ... > > I'll looks at another one later. > > Paul > > Vivek Titarmare wrote: >> >> Up till now we have uploaded 5 webrev's and below are the links for the >> same. >> >> http://cr.opensolaris.org/~vivekrt/6816378-mvel >> http://cr.opensolaris.org/~vivekrt/6816382-jettison >> http://cr.opensolaris.org/~vivekrt/6816384-jodatime >> http://cr.opensolaris.org/~vivekrt/6816392-jaxen-core >> http://cr.opensolaris.org/~vivekrt/6816393-janino > > > Comments .. > >>>> 1. METADATA >>>> You have ... >>>> BUGTRAQ: solaris/utility/drools >>>> wouldn't it be better if each component part had >>>> its own category, eg .. >>>> BUGTRAQ: solaris/utility/janino >>>> or if you can have this maybe .. >>>> BUGTRAQ: solaris/utility/drools/janino >>>> >>>> 2. install-sfw >>>> In the install-sfw scripts I looked at you have the >>>> pkg name and its version hardcoded in the scripts, >>>> it might be better if you pass this in from the >>>> Makefile.sfw as an env variable (or option), eg. in >>>> janino change ... >>>> janino/Makefile.sfw >>>> 43 VERS=$(VER) $(SHELL) ./install-sfw >>>> janino/install-sfw >>>> 66 cd ${VERS}/dist >>>> 69 _install N ${VERS}.jar ${JARDIR}/${VERS}.jar 444 >>>> etc. >>>> You will then not have to keep changing them every time >>>> the pkg version is updated. >>>> >>>> 3. Drools top level >>>> How are all the component pkgs pulled together to >>>> ensure anyone who wants to install Drools has all the >>>> component parts installed? 4. pkgdefs/SUNWjanino As this is java shouldn't it have a dependency on the package that delivers Java ? -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
