Hi Paul, I have updated the webrev. Pl. verify and let me know.
url:: http://cr.opensolaris.org/~vivekrt/6825758-antlr2bug/ Thanks, ~Vivek R. Titarmare -----Original Message----- From: [email protected] [mailto:sfwnv-discuss-bounces at opensolaris.org] On Behalf Of Vivek Titarmare Sent: Monday, April 06, 2009 3:56 PM To: paul.cunningham at tadpole.com Cc: sfwnv-discuss at opensolaris.org Subject: Re: [sfwnv-discuss] Request code review for "antlr277" Hi Paul, Yes, that can be used instead. I will update the webrev with the changes. Thanks, ~Vivek R. Titarmare -----Original Message----- From: Paul Cunningham [mailto:[email protected]] Sent: Monday, April 06, 2009 3:51 PM To: Vivek Titarmare Cc: sfwnv-discuss at opensolaris.org Subject: Re: [sfwnv-discuss] Request code review for "antlr277" Looks okay to me, but in usr/src/lib/antlr2/Makefile.sfw why not use $(CONFIGURE_OPTIONS), from Makefile.master, for the configure, eg ... change ... 48 ./configure --prefix=$(CFGPREFIX) ) to ... ./configure $(CONFIGURE_OPTIONS) Paul Vivek Titarmare wrote: > > I have posted a webrev for "antlr 2.7.7" package which has a bug fix for > 6825758 and would like to request a code review. > > Please see http://cr.opensolaris.org/~vivekrt/6825758-antlr2bug/ and provide > any comments as needed if there are any issues which I need to correct. -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit _______________________________________________ sfwnv-discuss mailing list sfwnv-discuss at opensolaris.org http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
