Ivan shi wrote: > Hi, > > I am porting "iozone", a filesystem benchmark tool. > > Could you please help to review the changes? The webrev is at: > http://cr.opensolaris.org/~ivanshi/iozone/
usr/src/cmd/iozone/METADATA - make the NAME long and PROGRAM short, and order fields like here: http://cr.opensolaris.org/~lxin/iperf/usr/src/cmd/iperf/METADATA.html - OWNER of package port is you. Remove the extra OWNER field. - Add BUGTRAQ field usr/src/cmd/iozone/Makefile.sfw 41 @find . -name core -exec rm -f {} \; - remove above if not needed 42 43 test: # there aren't any - removed above unused target - change "SH" to "SHELL" 46 $(SH) ./install-iozone 47 usr/src/cmd/iozone/install-iozone - add errexit 29 set -o errexit - you should be able to remove this line since VER is declared in Makefile.sfw 31 VER=iozone3_321 - change "." to "source" 39 . ${SRC}/tools/install.subr usr/src/pkgdefs/SUNWiozone/copyright - remove ^M at end. Where is usr/src/pkgdefs/SUNWiozone/Makefile? usr/src/pkgdefs/SUNWiozone/pkginfo.tmpl - include version like this 43 DESC="iozone - a filesystem benchmark tool (3_321)" Cheers, Jim
