Hi Steven, Thanks for your comments, response in line ...
Steven M. Christensen wrote: > Ivan - > > I have a few comments. There are several Solaris10 makefile options > for iozone as in the listing below. Your Makefile.sfw indicates you > are building the 32-bit version with cc. Have you considered building > the 64-bit binary also, or instead? > I call a common target Solaris10cc-64. If CFLAGS contains 64-bit flag, we will build 64-bit version, otherwise we build a 32-bit version. > Further, this version of iozone has a new program in it called fileop > which you might want to add as well. > Added, but iozone has linked to fileop.o object, and actually the program is useless, so I am still inclined to remove it if you agree. > You have the source file > > iozone3_321.tar > > Is it not normal for the source file to be compressed with gzip or bzip2? > The format exists web site of iozone, so I think it's convenient to update afterwards, We don't need to change anything. > That's all I have for now assuming you address Jim's issues. I have changed it according to Jim's comments. Please reload the link. Thanks, Ivan > > Steve C. > > > # > # Solaris 32 bit build with threads, largefiles, and async I/O > # > Solaris10: iozone_solaris10.o libasync10.o libbif10.o > fileop_Solaris10.o > $(CC) -O $(LDFLAGS) iozone_solaris10.o libasync10.o libbif10.o \ > -lthread -lpthread -lposix4 -lnsl -laio \ > -lsocket -o iozone > $(CC) -O fileop_Solaris10.o -o fileop > > # > # Solaris 32 bit build with threads, largefiles, and async I/O > # > Solaris10cc: iozone_solaris10cc.o libasync10cc.o libbif10cc.o > fileop_Solaris10cc.o > $(CC) -O $(LDFLAGS) iozone_solaris10cc.o libasync10cc.o > libbif10cc.o \ > -lthread -lpthread -lposix4 -lnsl -laio \ > -lsocket -o iozone > $(CC) -O fileop_Solaris10cc.o -o fileop > > # > # Solaris 32 bit build with threads, largefiles, and async I/O > # > Solaris10gcc: iozone_solaris10gcc.o libasync10.o libbif10.o > fileop_Solaris10gcc.o > $(GCC) -O $(LDFLAGS) iozone_solaris10gcc.o libasync10.o > libbif10.o \ > -lthread -lpthread -lposix4 -lnsl -laio \ > -lsocket -o iozone > $(GCC) -O fileop_Solaris10gcc.o -o fileop > > # > # Solaris 64 bit build with threads, largefiles, and async I/O > # > Solaris10gcc-64: iozone_solaris10gcc-64.o libasync10-64.o > libbif10-64.o fileop_Solaris10gcc-64.o > $(GCC) -O $(LDFLAGS) $(S10GCCFLAGS) iozone_solaris10gcc-64.o > libasync10-64.o libbif10-64.o \ > -lthread -lpthread -lposix4 -lnsl -laio \ > -lsocket -o iozone > $(GCC) -O $(S10GCCFLAGS) fileop_Solaris10gcc-64.o -o fileop > > > # > # Solaris 64 bit build with threads, largefiles, and async I/O > # > Solaris10cc-64: iozone_solaris10cc-64.o libasync10-64.o libbif10-64.o > fileop_Solaris10cc-64.o > $(CC) -O $(LDFLAGS) $(S10CCFLAGS) iozone_solaris10cc-64.o > libasync10-64.o libbif10-64.o \ > -lthread -lpthread -lposix4 -lnsl -laio \ > -lsocket -o iozone > $(CC) -O $(S10CCFLAGS) fileop_Solaris10cc-64.o -o fileop > > > > > > Ivan shi wrote: >> Resend ... >> >> Ivan shi wrote: >>> In case you missed it ... Anyone can help on this? Thanks in advance. >>> >>> >>> Ivan shi wrote: >>>> Hi, >>>> >>>> I am porting "iozone", a filesystem benchmark tool. >>>> >>>> Could you please help to review the changes? The webrev is at: >>>> http://cr.opensolaris.org/~ivanshi/iozone/ >>>> >>>> Thanks, >>>> Ivan >>> >> >> _______________________________________________ >> sfwnv-discuss mailing list >> sfwnv-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss >>
