Paul, Thanks for your review, see below ...
Paul Cunningham wrote: > Ivan, > > This mainly looks good, but see below ... > > Paul > > Ivan shi wrote: >>>>>> >>>>>> I am porting "iozone", a filesystem benchmark tool. >>>>>> >>>>>> Could you please help to review the changes? The webrev is at: >>>>>> http://cr.opensolaris.org/~ivanshi/iozone/ > > .. cut .. > > >>> 1. usr/src/cmd/Makefile >>> & usr/src/pkgdefs/Makefile >>> This needs resyncing with the gate so it doesn't >>> look as you are trying to change other stuff. >> OK, sync'ed. > > It still looks as though you are trying to remove 'iperf' still > Sync'ed again. :-) > ... cut ... > >>> 3. usr/src/cmd/iozone/iozone3_321.tar >>> Maybe you should compress this with bzip2 before >>> putting into your ws so it takes up less space. >>> >> >> Done. >> >>> 4. usr/src/cmd/iozone/Makefile.sfw >>> Change as .. >>> Roland Mainz wrote: >>> > use "env - ..." and not "env ..." in the Makefiles to >>> > make sure "configure"&&"make" only see the env variables >>> > they should really get (and not pick-up any random env >>> > variable) > > Line .. > 37 (cd $(SRC_ROOT); env \ > change to 'env - ' > I need to overwrite couple vars(CC and S10CCFLAGS) in the makefile of iozone to build the binary. CC specifies the path of cc and S10CCFLAGS decides 32-bit or 64-bit version to build. So I don't use "env -" > ... cut ... > >>> 6. usr/src/pkgdefs/SUNWiozone/copyright > > You also need to add the source owner copyright lines (if any) as > extracted from the unpacked src files in the tarball, see example in .. > "http://src.opensolaris.org/source/xref/sfw/usr/src/pkgdefs/SUNWmeld/copyright"; > > > Yes, I have extracted all copyright lines from the tarball, please see the bottom of the file. These files use different licenses. > ... cut .. > > Additional ... > 1. benchmark tool observation > The latest review email of sysbench says ... > > http://cr.opensolaris.org/~frival/sysbench-sfw/. Please note > > that I also changed the delivery directory for sysbench to > > /usr/benchmarks to more closely follow the other two benchmarks > > we deliver - filebench (ON) and bonnie++ (SFW). > so maybe as iozone is also a benchmark tool it should do the > same? > Good point, I have changed it. Please reload the link. Thanks, Ivan
