Thanks for the info, Steven. Please see my inline comments below.
cheers,
Simon
Steven M. Christensen wrote:
> Simon -
>
> A few questions/comments on your webrev.
>
> First, version 3.1.0 of libosip2 is more than a year old. The newest
> version is 3.3.0 which in my tests builds fine. Have you considered
> using this newer version? The ChangeLog is
>
> libosip2 (3.3.0)
> * new APPLE native interface for semaphore
> * add relative time in log information on linux/windows
> * fix: unescape last uri parameters.
>
> libosip2 (3.2.0)
> * return new error code for all API.
>
> Maybe these are not important enough, but don't we want to offer
> the most recent version when possible?
I check the latest one and it seem that I can put it in instead of the 3.1.0
>
> In the new version there is a libosip2.pc file in lib/pkgconfig. Does
> such a file exist in 3.1.0 and should it be included?
There is no such file in 3.1.0 and I don't know exactly what's the
purpose of it at this moment.
>
> What does the line in install-sfw and
>
> 55 f=`basename ${i}`
>
> do? I don't see a use for it. Should the f be an i?
Actually I can delete the line. It's obsolete. It was used to get the
file name which does not include the directory info and was used before
in the _install command.
>
> In the new version, there is a man1 file, not a man3lib file.
>
>
>
> Steve C.
>
>
>
>
> Simon Sun wrote:
>> Resend...
>>
>> Simon Sun wrote:
>>> Hi,
>>>
>>> I'm porting libosip2, a low layer SIP implementation.
>>>
>>> Please help to code review my modification. The webrev is at:
>>>
>>> http://cr.opensolaris.org/~dysun/libosip2/
>>>
>>> The comments will be changed accordingly once the subcategory gets
>>> approval. Thanks.
>>>
>>> cheers,
>>> Simon
>> _______________________________________________
>> sfwnv-discuss mailing list
>> sfwnv-discuss at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
>>
