Mainly looks okay to me now, but see below ... Paul
> Done and a new version generated at > http://cr.opensolaris.org/~dysun/libosip2/ > > Changes according to Paul's comments have been merged also. Simon Sun wrote: >>>> >>>> I'm porting libosip2, a low layer SIP implementation. >>>> >>>> Please help to code review my modification. The webrev is at: >>>> http://cr.opensolaris.org/~dysun/libosip2/ ... cut ... >> 1. usr/src/lib/libosip2/Makefile.sfw ... cut ... >> Apply this .. >> Roland Mainz wrote: >> > use either $(SHELL) or /usr/bin/bash for "configure" >> > calls (so we know which one is used and "configure" >> > doesn't pick one itself) You haven't done this as far as I can see Additional ... 1. usr/src/lib/libosip2/sunman-stability "Volatile" is probably not the correct Stability state any more. -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
