Simon Sun wrote: > Please help to code review my modification. The webrev is at: > > http://cr.opensolaris.org/~dysun/libosip2/
Looks good. Here are some comments: usr/src/lib/libosip2/METADATA - add NAME and SRC fields like here: http://cr.opensolaris.org/~lxin/iperf/usr/src/cmd/iperf/METADATA.html usr/src/lib/libosip2/libosip2.3lib - the attribute block should look more like this: http://cr.opensolaris.org/~lxin/iperf/usr/src/cmd/iperf/sunman-stability.html usr/src/pkgdefs/SUNWlibosip2/copyright - you need a disclaimer and copyright statements from the libosip2 source files in the copyright like is done here: http://cr.opensolaris.org/~hylee/pyopenssl26/usr/src/pkgdefs/SUNWpython26-pyopenssl/copyright.html usr/src/pkgdefs/SUNWlibosip2/pkginfo.tmpl - I would use this value 35 NAME="libosip2- GNU oSIP library" - I would use this value, version needed 43 DESC="libosip2 - GNU oSIP library (3.1.0) Cheers, Jim
