Huie-Ying, This mainly looks good, see my comments below ...
Paul Huie-Ying Lee wrote: > > The PyOpenSSL package for Python 2.4 (SUNWpython-pyopenssl) was > integrated to SFWNV, build 106. Because Python 2.6 has been added to > Solaris in build 109 and Python 2.4 will be obsolete in the future, we > need to add the PyOpenSSL package support for Python 2.6. > Please help review code for the PyOpenSSL package, Python 2.6 support. > > PSARC case: PSARC 2009/176 (approved on March 19 2009) > > webrev: http://cr.opensolaris.org/~hylee/pyopenssl26/ 1. USER MANUAL > Note that the pyOpenSSL user manual has been included in the existing > SUNWpython-pyopenssl package. Because the SFW cteam recommended to > deliver the document once only, the document > (/usr/share/doc/pyOpenSSL/pyOpenSSL.txt) will be included in the new > SUNWpython26-pyopenssl package, but it will be removed from the existing > SUNWpython-pyopenssl package. Why not deliver this in a separate docs SUNW package, eg. SUNWpython-pyopenssl-doc 2. usr/src/lib/python26-pyopenssl/METADATA Line .. 6 SRC: pyOpenSSL-0.8.tar.gz from http://pyopenssl.sourceforge.net this should probably be a URL to the tarball file, eg. SRC: http://pyopenssl.sourceforge.net/..../pyOpenSSL-0.8.tar.gz You can probably delete the last line (13) Line ... 5 URL: http://pyopenssl.sourceforge.net wouldn't 'http://sourceforge.net/projects/pyopenssl/' be a better link - as it tells you what it is? 3. usr/src/lib/python26-pyopenssl/install-sfw Line .. 1 #!/bin/ksh93 should probably be .. #!/usr/bin/ksh93 4. man pages Should this pkg also deliver some man-pages ? 5. usr/src/pkgdefs/SUNWpython26-pyopenssl/depend Line .. 56 P SUNWPython is this the correct dependency if its for python 2.6 ? -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
