On 04/14/09 04:12, Paul Cunningham wrote: Hi Paul,
> Huie-Ying, > > Did a quick skip through and it mainly looks good now, but see below .. > > Paul > > Huie-Ying Lee wrote: >>> Huie-Ying Lee wrote: >>>> The PyOpenSSL package for Python 2.4 (SUNWpython-pyopenssl) was >>>> integrated to SFWNV, build 106. Because Python 2.6 has been added >>>> to Solaris in build 109 and Python 2.4 will be obsolete in the >>>> future, we need to add the PyOpenSSL package support for Python 2.6. >>>> Please help review code for the PyOpenSSL package, Python 2.6 support. >>>> >>>> PSARC case: PSARC 2009/176 (approved on March 19 2009) >>>> >>>> webrev: http://cr.opensolaris.org/~hylee/pyopenssl26/ > <snip> > >>> 2. usr/src/lib/python26-pyopenssl/METADATA >>> Line .. >>> 6 SRC: pyOpenSSL-0.8.tar.gz from http://pyopenssl.sourceforge.net >>> this should probably be a URL to the tarball file, eg. >>> SRC: http://pyopenssl.sourceforge.net/..../pyOpenSSL-0.8.tar.gz >> As of today, the link to the tar ball is >> http://sourceforge.net/project/downloading.php?group_id=31249&filename=pyOpenSSL-0.8.tar.gz&a=76220575 >> >> >> This doesn't seem to be permanent address to me. I think it >> should not be too hard to fine the tar ball from >> http://pyopenssl.sourceforge.net, so I think it is better to not >> change this SRC line. > > Isn't the following link a stable one ? (ie. the 'direct link') ... > "http://kent.dl.sourceforge.net/sourceforge/pyopenssl/pyOpenSSL-0.8.tar.gz"; > > Yes, the link you suggested above is good. I will change it. BTW, could you please tell me how you found this stable link ? <snip> > Additional ... > > 1. > Line ... > 47 (cd $(VER64); env \ > you could change that to 'env - ' > OK. Fixed. The webrev is updated. Please see http://cr.opensolaris.org/~hylee/pyopenssl26/ Thanks, Huie-Ying
