On 04/09/09 01:47, Paul Cunningham wrote: Hello Paul,
> Huie-Ying, > > This mainly looks good, see my comments below ... > > Paul > > Huie-Ying Lee wrote: >> >> The PyOpenSSL package for Python 2.4 (SUNWpython-pyopenssl) was >> integrated to SFWNV, build 106. Because Python 2.6 has been added >> to Solaris in build 109 and Python 2.4 will be obsolete in the >> future, we need to add the PyOpenSSL package support for Python 2.6. >> Please help review code for the PyOpenSSL package, Python 2.6 support. >> >> PSARC case: PSARC 2009/176 (approved on March 19 2009) >> >> webrev: http://cr.opensolaris.org/~hylee/pyopenssl26/ > > > 1. USER MANUAL >> Note that the pyOpenSSL user manual has been included in the existing >> SUNWpython-pyopenssl package. Because the SFW cteam recommended to >> deliver the document once only, the document >> (/usr/share/doc/pyOpenSSL/pyOpenSSL.txt) will be included in the new >> SUNWpython26-pyopenssl package, but it will be removed from the >> existing SUNWpython-pyopenssl package. > > Why not deliver this in a separate docs SUNW package, eg. > SUNWpython-pyopenssl-doc > Thank you for the suggestion. I have visited this issue already and the result is that SFW cteam suggested to remove the document from the existing package (which will be obsolete in the future), and deliver the document in the new SUNWpython26-pyopenssl package only. This arrangment has been approved by the package team also. > 2. usr/src/lib/python26-pyopenssl/METADATA > Line .. > 6 SRC: pyOpenSSL-0.8.tar.gz from http://pyopenssl.sourceforge.net > this should probably be a URL to the tarball file, eg. > SRC: http://pyopenssl.sourceforge.net/..../pyOpenSSL-0.8.tar.gz > As of today, the link to the tar ball is http://sourceforge.net/project/downloading.php?group_id=31249&filename=pyOpenSSL-0.8.tar.gz&a=76220575 This doesn't seem to be permanent address to me. I think it should not be too hard to fine the tar ball from http://pyopenssl.sourceforge.net, so I think it is better to not change this SRC line. > You can probably delete the last line (13) > OK. fixed. > Line ... > 5 URL: http://pyopenssl.sourceforge.net > wouldn't 'http://sourceforge.net/projects/pyopenssl/' be a > better link - as it tells you what it is? > OK. fixed. > 3. usr/src/lib/python26-pyopenssl/install-sfw > Line .. > 1 #!/bin/ksh93 > should probably be .. > #!/usr/bin/ksh93 > Fixed. > 4. man pages > Should this pkg also deliver some man-pages ? > No, there is no man pages for Python bindings, as we discussed before for pyOpenSSL 2.4 code review in December. > 5. usr/src/pkgdefs/SUNWpython26-pyopenssl/depend > Line .. > 56 P SUNWPython > is this the correct dependency if its for python 2.6 ? > Good catch. It should be SUNWPython26. The webrev is updated. Please see http://cr.opensolaris.org/~hylee/pyopenssl26/ Thanks, Huie-Ying
