Vivek Titarmare wrote: > Hi Paul, > > Ok. I will add those dependencies to all the packages I have sent for > review. > Also if the depend file is updated, do I need to send for the code review > again or I can consider as code review done.
I happy for you just to send out one of the update webrevs with changes; I'll assume the others are okay. But whoever does your RTI may want them all sent out again. Paul > > -----Original Message----- > From: Paul Cunningham [mailto:paul.cunningham at tadpole.com] > Sent: Tuesday, April 14, 2009 3:44 PM > To: Vivek Titarmare > Cc: sfwnv-discuss at opensolaris.org > Subject: Re: [sfwnv-discuss] Request code review for "jodatime" > > > > Vivek Titarmare wrote: >> Hi Paul, >> >> Yes, we can add those depend file. However this dependency was not caught > by >> check_deps script. I had executed make check_deps script for all the >> packages and none of them list the dependency on java runtime pkg. >> >> I can add the below lines if required to all the depend files. >> P SUNWj5rt JDK 1.5 run time environment >> P SUNWj5dev JDK 1.5 development tools > > Personally I think you should add them. > I can't comment on the check_deps script as I have never really looked > at it - maybe it's a bug in that script. > > Paul >> -----Original Message----- >> From: Paul Cunningham [mailto:paul.cunningham at tadpole.com] >> Sent: Tuesday, April 14, 2009 3:17 PM >> To: Vivek Titarmare >> Cc: sfwnv-discuss at opensolaris.org >> Subject: Re: [sfwnv-discuss] Request code review for "jodatime" >> >> >> >> Vivek Titarmare wrote: >>> Yes, dependencies are Ok. Thanks Paul. >> This applies to them all; but surely as you are delivering a jar file >> doesn't that require the java runtime pkg stuff to be of any use? >> >> paul >>> -----Original Message----- >>> From: Paul Cunningham [mailto:paul.cunningham at tadpole.com] >>> Sent: Tuesday, April 14, 2009 3:04 PM >>> To: Vivek Titarmare >>> Cc: sfwnv-discuss at opensolaris.org >>> Subject: Re: [sfwnv-discuss] Request code review for "jodatime" >>> >>> Vivek, >>> >>> and again, this looks good to me (assuming dependencies are okay) >>> >>> Paul >>> >>> Vivek Titarmare wrote: >>>> I have posted a webrev for package "jodatime" which I am porting to >>>> OpenSolaris and would like to request a code review. >>>> >>>> Please see below link >>>> http://cr.opensolaris.org/~vivekrt/6816384-jodatime/ > -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
