Hi Alan, Thanks for the detail explanation. I will take care the next time. JDK 1.5 is not really required. JDK 1.6 would also work, however the dependency list has been picked up from the ant depend file which had JDK 1.5.
Let me see If I can change it to JDK 1.6. At presently I have uploaded all the 10 webrev's with the new depends file. Thanks, ~Vivek R. Titarmare -----Original Message----- From: Alan.Coopersmith at Sun.COM [mailto:[email protected]] Sent: Tuesday, April 14, 2009 7:48 PM To: Vivek Titarmare Cc: paul.cunningham at tadpole.com; sfwnv-discuss at opensolaris.org Subject: Re: [sfwnv-discuss] Request code review for "jodatime" check-deps doesn't know how to check Java dependencies - the current version in widespread use knows how to check ELF binaries generated by C/C++ code and #! scripts, but that's it - it's a tool to assist you find dependencies that you may have missed, not a complete verification of all possible dependencies. Also, if you really require JDK 1.5, you've got a problem, since OpenSolaris only includes JDK 1.6. -Alan Coopersmith- alan.coopersmith at sun.com Sun Microsystems, Inc. - X Window System Engineering Vivek Titarmare wrote: > Hi Paul, > > Yes, we can add those depend file. However this dependency was not caught by > check_deps script. I had executed make check_deps script for all the > packages and none of them list the dependency on java runtime pkg. > > I can add the below lines if required to all the depend files. > P SUNWj5rt JDK 1.5 run time environment > P SUNWj5dev JDK 1.5 development tools > > Pl. suggest. > > Thanks in advance, > ~Vivek R. Titarmare > > -----Original Message----- > From: Paul Cunningham [mailto:paul.cunningham at tadpole.com] > Sent: Tuesday, April 14, 2009 3:17 PM > To: Vivek Titarmare > Cc: sfwnv-discuss at opensolaris.org > Subject: Re: [sfwnv-discuss] Request code review for "jodatime" > > > > Vivek Titarmare wrote: >> Yes, dependencies are Ok. Thanks Paul. > > This applies to them all; but surely as you are delivering a jar file > doesn't that require the java runtime pkg stuff to be of any use? > > paul >> -----Original Message----- >> From: Paul Cunningham [mailto:paul.cunningham at tadpole.com] >> Sent: Tuesday, April 14, 2009 3:04 PM >> To: Vivek Titarmare >> Cc: sfwnv-discuss at opensolaris.org >> Subject: Re: [sfwnv-discuss] Request code review for "jodatime" >> >> Vivek, >> >> and again, this looks good to me (assuming dependencies are okay) >> >> Paul >> >> Vivek Titarmare wrote: >>> I have posted a webrev for package "jodatime" which I am porting to >>> OpenSolaris and would like to request a code review. >>> >>> Please see below link >>> http://cr.opensolaris.org/~vivekrt/6816384-jodatime/ >> >
