Vivek, See comments below, but it mainly looks good ...
Vivek Titarmare wrote: > I have posted a webrev for package "objectasm" which I am porting to > OpenSolaris and would like to request a code review. > > Please see below link > http://cr.opensolaris.org/~vivekrt/6816387-objectasm/ 1. usr/src/lib/objectasm/install-sfw Lines ... 73 _install N asm-commons-3.1.jar ${JARDIR}/asm-commons-3.1.jar 444 74 _install L asm-commons-3.1.jar ${JARDIR}/asm-commons.jar 444 could you pass the version number in from the Makefile.sfw ? 2. usr/src/lib/objectasm/sunman/asm.3 Line ... 41 /usr/share/lib/java/asm-3.1.jar does this need the version number on it as there is also a symbolic link without the ver ? This may apply to other packages also! 3. usr/src/pkgdefs/SUNWobjectasm/depend Move the Copyright lines and fix file top to conform to .. "http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/prototypes/"; Copyright year is wrong Version of JDK stuff, is that correct ? 4. usr/src/pkgdefs/SUNWobjectasm/copyright Should this also say what licence it is ? END -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
