Peter, Did a quick skip through and this mainly looks okay to me, but see below ...
Paul Peter Rival wrote: > > I *think* I've addressed all the comments from both Amanda and Paul. > The webrev has been updated and can be found at > http://cr.opensolaris.org/~frival/sysbench-sfw/. Please note that I > also changed the delivery directory for sysbench to /usr/benchmarks to > more closely follow the other two benchmarks we deliver - filebench (ON) > and bonnie++ (SFW). Any further comments would be most appreciated. 1. usr/src/cmd/sysbench/Makefile.sfw You have said above (and in install-sfw & prototype_com) that you now deliver it into /usr/benchmarks, but in Makefile.sfw your 'configure --prefix=...' does not reflect that the binary will install into /usr/benchmarks/sysbench. Maybe the configure options should be setup to that as appropriate, eg. .. --bindir=/usr/benchmarks/sysbench -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
