Peter, See my comments below, but it mainly looks good to me ...
Paul Peter Rival wrote: > > I posted a code review request for my porting work on sysbench on the > forum about a week ago and haven't heard any responses yet. Since it's > possible the forum<->mail gateway didn't gateway I thought I'd send out > the request again. You can find the webrev at > http://cr.opensolaris.org/~frival/sysbench-sfw/ === Start of Comments === 1. usr/src/cmd/sysbench/METADATA Change so it conforms to that in ... "http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines"; 2. usr/src/cmd/sysbench/install-sfw & usr/src/pkgdefs/SUNWsysbench/prototype_com Remove the write permission from files install into /usr 3. CDDL HEADER and top of file (various files) Cosmetic: Change so that they conform to the prototypes in .. "http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/prototypes/"; its mainly, extra # line at top and a missing line space after the CDDL HEADER END # 4. usr/src/cmd/sysbench/sysbench.1.sunman You need to add the line about where the source can be found from Sun (at the end). 5. usr/src/pkgdefs/SUNWsysbench/depend Line ... 53 P SUNWmysqlr mysql - MySQL ... (usr component) should that be 'root' ? 6. usr/src/pkgdefs/SUNWsysbench/pkginfo.tmpl Add the pkg version number on the DESC= line, eg... DESC="......... (0.4.10)" 7. usr/src/pkgdefs/SUNWsysbench/prototype_i386 & usr/src/pkgdefs/SUNWsysbench/prototype_sparc Cosmetic: you could change so it conforms to the layout in ... "http://src.opensolaris.org/source/xref/sfw/usr/src/pkgdefs/SUNWmeld/prototype_i386"; etc. === End of Comments ===== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
