Hi Peter, 1. Regarding Paul's point about the PREFIX. It would probably be better if in Makefile.sfw you did a 'make install' in your install target with the prefix set to '/usr/benchmarks/sysbench' and with DESTDIR set to point to $(ROOT). You could then tidy up the file permissions and strip the binary in situ using protofix rather than having to _install it. You probably know better than me though and took the decision to install the binary directly from the build directory for good reasons.
Otherwise it looks ok. Amanda Peter Rival wrote: > Hi all, > > I *think* I've addressed all the comments from both Amanda and Paul. > The webrev has been updated and can be found at > http://cr.opensolaris.org/~frival/sysbench-sfw/. Please note that I > also changed the delivery directory for sysbench to /usr/benchmarks to > more closely follow the other two benchmarks we deliver - filebench > (ON) and bonnie++ (SFW). Any further comments would be most > appreciated. Thanks! > > - Pete > > Amanda Waite wrote: >> The MySQL dependencies are a little strange. In the depend file you >> have dependencies on MySQL 4 and MySQL 5. Do you really need to >> depend on having MySQL 4 installed? You could remove the MySQL 5.0 >> version number from the lines in the depend file so that you don't >> need to keep updating it every time MySQL revs, besides MySQL 5.0 is >> at 5.0.67 in Nevada currently (and will soon be udpated to 5.0.77). >> What about 5.1? That's in Nevada from b111. >> >> In fact isn't it kind of backwards? presumably you want to run >> Sysbench against a DB you already have installed, not install it and >> have it pull down two other versions of MySQL. Maybe Sysbench >> shouldn't have a dependency on MySQL at all and you should build it >> against the version of MySQL that gives you options for use with as >> many versions of MySQL as possible. If built against 5.1 will it then >> work with 5.1.x, 5.0.x, 4.x...? >> >> In the Makefile you build with --with-mysql=/usr/mysql which will be >> either 5.0 or 5.1 depending on which version of Nevada you build on. >> If you build on snv_111 using that flag it will build against MySQL >> 5.1.30 which currently may not be what you are expecting. >> >> As I found out yesterday, it's generally better to build against a >> specific version and to build using the MySQL from the SFW workspace >> (i.e.: --with-mysql=$(ROOT)/usr/mysql/5.0). If you do then you need >> to specify a dependency on MySQL which (again as I found out >> yesterday) is done at the bottom of usr/src/cmd/Makefile with a line >> like: >> >> sysbench: mysql-5-0 >> >> Amanda >> >> Peter Rival wrote: >>> Hi all, >>> >>> I posted a code review request for my porting work on sysbench on >>> the forum about a week ago and haven't heard any responses yet. >>> Since it's possible the forum<->mail gateway didn't gateway I >>> thought I'd send out the request again. You can find the webrev at >>> http://cr.opensolaris.org/~frival/sysbench-sfw/ >>> <http://cr.opensolaris.org/%7Efrival/sysbench-sfw/>. Thanks! >>> >>> - Pete >>> _______________________________________________ >>> sfwnv-discuss mailing list >>> sfwnv-discuss at opensolaris.org >>> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss >> >
