Hi Paul, Thanks very much . I will make the change.
Regards, Rusong Paul Cunningham ??: > Hi, > > This looks good, just a couple of very minor comments, see below ... > > I don't need to review again. > Paul > > > Rusong.Zheng wrote: >> >> Thanks for your review. I have made changes as below: >> http://cr.opensolaris.org/~rszheng/jedit/ > > >>> 1. usr/src/cmd/jedit/Makefile.sfw > ... cut .. >>> >> It should be JEDIT_SRC_DIR, "clean" section now are: >> >> 59 clean: >> 60 -rm -rf $(JEDIT_SRC_DIR); >> 61 -rm -rf $(JEDIT_NOT_USE); >> 62 -rm -f jedit > > You could do that in one invocation of 'rm', eg ... > > -rm -rf $(JEDIT_SRC_DIR) $(JEDIT_NOT_USE) jedit > > > ... cut ... > > 2. usr/src/pkgdefs/SUNWjedit/depend > Cosmetic: Lines ... > 24 # Use is subject to license terms. > 25 #ident "@(#)depend 1.1 09/04/16 SMI" > you could add the line-spacing gap between these lines > as in .. > "http://cr.opensolaris.org/~rszheng/jedit/usr/src/cmd/jedit/Makefile.sfw.html"; > > > > 3. SCCS ident lines (SUNWjedit/* files) > Missed before ... > Cosmetic: remove the 'pragma ' on these lines > #pragma ident "@(#)Makefile 1.5 09/04/16 SMI" > its not required. >
