rusong.zheng wrote: > Hi, > > Per ARC's request, changes to webrev are : > > /usr/share/jedit/4.3pre16/ ==>/usr/share/jedit/ > > sunman/jedit.1 ==>jedit.1 sunman is > removed > build.xml.patch ==>patches/build.xml.patch > build.properties.patch ==>patches/build.properties.patch > jedit.patch ==>patches/jedit.patch > > directory classes is removed for that contents of it are duplicated > (class files and API docs, class files already be contained in > jedit.jar, APIs doc already in doc/API/) > jedit is removed from /usr/share/jedit/jedit and moved to /usr/bin/jedit > > Makefile.sfw, install_sfw and prototype_com are changed accordingly. > > Besides that, METADATA file has been changed to meet the new > requirement. All the others are the same as the last round of review. > > Please help review them. > > Webrev is at: > http://cr.opensolaris.org/~rszheng/jedit/ > > PSARC case url is: > http://arc.opensolaris.org/caselog/PSARC/2009/357/ I'm confused about the script "jedit", and I'll admit it's because this is the first java->sfw project I've code reviewed. That, and my Make is probably a little rusty.
It occurs to me that the patch creates a file jedit.sh. If that is true: a) Where is "jedit" that's been referenced as /usr/bin/jedit b) Is that the appropriate name?
