Jim Walker wrote: > Eddie Luo wrote: >> Hi all, >> >> I'm porting lua, a powerful, fast, light-weight, embeddable scripting >> language, which is widely used as scripting language in video game >> development. Could you help take some time to review? You can find >> the webrev >> at: http://cr.opensolaris.org/~eddie/lua/ >> > > Here's a few comments: > > Please update all the files with the correct CDDL header and > copyright header formats. Here's an example: > http://cr.opensolaris.org/~jwalker/meld/usr/src/cmd/Makefile.html >
Done. > Since lua is primarily a library, I would base it at: > usr/src/lib instead of usr/src/cmd, and move your files > to the usr/src/lib directory. > I'd like to put it under /usr/src/cmd as it's similar with ruby, python, etc. > usr/src/Targetdirs > - you won't need to update Targetdirs much > since most of the lua files can go into > know locations: > <snip> > Change package name to SUNWlua and change > the name of the pkgdefs directory to SUNWlua. > > Update the pkginfo.tmpl and prototype* files accordingly. There are some differences between "lua" and your "meld", say lua-5.1.4/Makefile, lua-5.1.4/src/Makefile and meld/GNUmakefile. I've updated my workspace based on most of your comments and successfully rebuild the lua package with SS12, could you help review the changes? New webrev can be found at the same place: http://cr.opensolaris.org/~eddie/lua/. Thanks, Eddie
