Jim Walker wrote:
> Eddie Luo wrote:
>>
>>> Since lua is primarily a library, I would base it at:
>>> usr/src/lib instead of usr/src/cmd, and move your files
>>> to the usr/src/lib directory.
>>>
>>
>> I'd like to put it under /usr/src/cmd as it's similar with ruby,
>> python, etc.
>
> Ok. But you may need to change later.
>
>>>
>>> Update the pkginfo.tmpl and prototype* files accordingly.
>>
>> There are some differences between "lua" and your "meld", say
>> lua-5.1.4/Makefile, lua-5.1.4/src/Makefile and meld/GNUmakefile.
>> I've updated my workspace based on most of your comments and
>> successfully rebuild the lua package with SS12, could you help review
>> the changes?
>>
>> New webrev can be found at the same place:
>> http://cr.opensolaris.org/~eddie/lua/.
>>
>
> Remove extra leading spaces in all CDDL headers
> 2 # CDDL HEADER START
> ...
> should be:
> 2 # CDDL HEADER START
> ...
Will fix. Enn, I read the header from usr/src/cmd/meld/Makefile.sfw so
it seems that it also has this problem.
>
> usr/src/cmd/lua/install-sfw
> - since you are using MANSCRIPT you can change N to M in
> _install.
> 37 MANSCRIPT=../sunman-stability
> 46 _install M doc/lua.1 ${MAN1DIR}/lua.1 444
> 47 _install M doc/luac.1 ${MAN1DIR}/luac.1 444
>
Will do.
>
> usr/src/pkgdefs/SUNWlua/pkginfo.tmpl
> 35 NAME="Lua Programming language (usr)"
> - remove "(usr)".
>
Will do.
> Otherwise, look good.
>
> Good job!
>
> Let me know when you have ARC materials and I
> can sponsor you.
>
> Cheers,
> Jim
Ok.
Thanks,
Eddie
