2.continue.... Makefile.sfw in 'diffstat' is my referenc:
http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/diffstat/Makefile.sfw ? 12/10/08 12:20, Zhang Xiao Ping ??: > Hi jim, > > I have two questions. > > 1. > > 47 clean: > 48 -rm -rf $(VER) > > These can be found not only in eddie's code but also almost in every > Makefile.sfw. > > Why need '-' before 'rm' and what does it means? I did not seen > Makefile like this before. > > And in my code, i did not use '-', is it right? > > > 2. > http://tas.eng/export/pub/richard/ws/sfwnv/webrev/ > > > The following two both fail ad line 41, error message in mail is: > > ==== Make clobber ERRORS ==== > > dmake: Fatal error in reader: Makefile.sfw, line 41: Unexpected end of > line seen > dmake: Warning: Command failed for target `conflict' > dmake: Warning: Target `clobber' not remade because of errors > dmake: Warning: Target `clobber' not remade because of errors > > > These are code in Makefile.sfw: > > 40 $(VER)/Makefile: $(VER)/configure > 41 (cd $(VER); env CC=$(CC) MAKE=$(CCSMAKE) ./configure) > > > 40 $(VER)/Makefile: $(VER)/configure > 41 (cd $(VER); ./configure) > > > Thanks. > > > ? 12/09/08 17:04, Jim Walker ??: >> Eddie Luo wrote: >>>>> New webrev can be found at the same place: >>>>> http://cr.opensolaris.org/~eddie/lua/. >>>>> >>>> >>>> Remove extra leading spaces in all CDDL headers >>>> 2 # CDDL HEADER START >>>> ... >>>> should be: >>>> 2 # CDDL HEADER START >>>> ... >>> >>> Will fix. Enn, I read the header from usr/src/cmd/meld/Makefile.sfw >>> so it seems that it also has this problem. >> >> I forgot. I'm going to update that soon. Maybe I will >> use your webrev as an example :) >> >> Looks good. >> >> Good job! >> >> Cheers, >> Jim >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.opensolaris.org/pipermail/sfwnv-discuss/attachments/20081210/49808408/attachment.html>
