Eddie, Here are a few comments ...
Paul Eddie Luo wrote: .... cut ... > > New webrev can be found at the same place: > http://cr.opensolaris.org/~eddie/lua/. === Start of Comments === 1. CDDL headers (most new files) Cosmetic, remove the double space as the start of the lines in these headers. eg. change ... # ..... to # ..... 2. usr/src/cmd/lua/install-sfw Shouldn't the install of the man pages be done with (M).. _install M doc/lua.1 so they are modified with the sunman-stability stuff. Do you also need the modify the file permissions installed in the proto area (by 'make install') in here so they correspond to the permissions in SUNWlua/prototype_com? If they are different doesn't it get reported at the end of the full ws build. 3. usr/src/cmd/lua/Makefile.sfw How does ... 41 $(MAKE) install) know to install it in the ws proto area ? I assume the tarball unpack and patching is done implicitly rather than explicitly in here. Personally I prefer to see things done explicitly so I know what is going on (ignore this comment if you are happy). === End of Comments ===== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
