Eddie Luo wrote: > Paul Cunningham wrote: >> Eddie, >> >> Here are a few comments ... >> >> Paul >> >> Eddie Luo wrote: >> .... cut ... >>> >>> New webrev can be found at the same place: >>> http://cr.opensolaris.org/~eddie/lua/. >> > <cut> >> 3. usr/src/cmd/lua/Makefile.sfw >> How does ... >> 41 $(MAKE) install) >> know to install it in the ws proto area ? > > It's controlled by tarball's Makefile & src/Makefile after patching, > see below tarball's Makefile after unpacked and patching: > [zl162101 at mogo lua]$cat lua-5.1.4/Makefile > # makefile for installing Lua > # see INSTALL for installation instructions > # see src/Makefile and src/luaconf.h for further customization > > # == CHANGE THE SETTINGS BELOW TO SUIT YOUR ENVIRONMENT > ======================= > > # Your platform. See PLATS for possible values. > PLAT= none > > # Where to install. The installation starts in the src and doc > directories, > # so take care if INSTALL_TOP is not an absolute path. > INSTALL_TOP= $(ROOT)/usr > INSTALL_BIN= $(INSTALL_TOP)/bin > INSTALL_INC= $(INSTALL_TOP)/include > INSTALL_LIB= $(INSTALL_TOP)/lib > #INSTALL_MAN= $(INSTALL_TOP)/man/man1 > INSTALL_DOC= $(INSTALL_TOP)/share/doc/lua > INSTALL_TEST= $(INSTALL_TOP)/lib/lua/test > # > # You probably want to make INSTALL_LMOD and INSTALL_CMOD consistent with > # LUA_ROOT, LUA_LDIR, and LUA_CDIR in luaconf.h (and also with > etc/lua.pc). > INSTALL_LMOD= $(INSTALL_TOP)/share/lua/$V > INSTALL_CMOD= $(INSTALL_TOP)/lib/lua/$V > > # How to install. If your install program does not support "-p", then you > # may have to run ranlib on the installed liblua.a (do "make ranlib"). > INSTALL= ginstall -p > INSTALL_EXEC= $(INSTALL) -m 0555 > INSTALL_DATA= $(INSTALL) -m 0644 Should be: INSTALL_DATA= $(INSTALL) -m 0444
New webrev is at the same place: http://cr.opensolaris.org/~eddie/lua/ Thanks, Eddie
