Hi Xiao,
Adding to Muktha's and Amanda's comments.
1. In Makefile.sfw,
* It appears that you are setting "CC" to gcc at configure time but
the same is not done in the target "all" while doing make. Please
make sure that the env passed is same both at configure time and
while running make. Changing 'env' to 'env -' would help you catch
these errors.
2. In install-sg3,
* you could have a for loop to install the binaries/docs as shown below:
SG3_BIN_LIST="\
sg_rmsn \
sg_readcap
...
sg_stpg"
for i in ${SG3_BIN_LIST}
do
_install D ${PKGVERS}/src/.libs/${i} ${LIBDIR}/${i} 555
done
* The *.8 manpages are renamed as *.1 and are installed into man1
dir. Is this intended ?
It is fine, If these man pages are for "user commands". Here in
this case I think the binaries are admin tools which only root
user / users having root role can execute, so I guess they need to
be in section 8. Please check the same.
3. "sunman-stability" needs to be modified to remove references to
SUNWgzip and its entries.
4. In usr/src/pkgdefs/Makefile, please add the component entry in
alphabetical order.
5. In SUNWsg3utilsr/prototype_i386 file, the Copyright should be put
after the "CDDL HEADER END".
Also please check the CDDL headers in other files too.
Below link has the prototype CDDL headers.
-
http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/prototypes/
6. In SUNWsg3utilsu/prototype_com file, do you require write permission
for the library "libsgutils.so.1.0.0" ? If not please make it 555.
Thanks,
Srirama
xiao li - Sun Microsystems - Beijing China said the following on Tuesday
16 December 2008 02:45 PM:
> Hi Experts,
> I'm responsible for integrating sg3 utilities into opensolaris.
> My code change is available at:
> http://cr.opensolaris.org/~xl222276/sg3utils
>
> You comments will be highly appreciated.
>
> Thanks and regards,
> -Xiao
>
>
>
> _______________________________________________
> sfwnv-discuss mailing list
> sfwnv-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://mail.opensolaris.org/pipermail/sfwnv-discuss/attachments/20081216/8f45b7b8/attachment.html>
