Looks good to me.
Amanda
xiao li - Sun Microsystems - Beijing China wrote:
> Hi Amanda,
> Please see my comments below.
>
> Amanda waite wrote:
>
>> xiao li - Sun Microsystems - Beijing China wrote:
>>
>>>> - test without the find $(VER) ... statements as they probably
>>>> aren't needed and just add
>>>> overhead to the build
>>>>
>>> Not quite understand this.
>>>
>> The statements:
>>
>> find $(VER) -type d -exec /usr/bin/chmod 755 "{}" \;
>> find $(VER) -type f -exec /usr/bin/chmod ugo+r "{}" \
>>
>> are often unnecessary and are commonly included when using another
>> component's Makefile.sfw as a template. Check to see if they really
>> are needed, if not remove them
>>
> Ok, checked and removed.
>
>>
>>>> - Use ksh93 as described here::
>>>>
>>>> Roland Mainz wrote:
>>>> > use /usr/bin/ksh93 or /usr/bin/bash for install-sfw*
>>>> > and add a
>>>> > $ set -o errexit # at the beginning and replace
>>>> > ". > ${SRC}/tools/install.subr" with
>>>> > "source ${SRC}/tools/install.subr" (the idea is to
>>>> > catch failures in the script and abort it at that
>>>> > point, right now the script will just continue)
>>>>
>>>>
>> I noticed you're still using ksh as the shebang of the install-sfw
>> script, change it to /usr/bin/ksh93
>>
> Fixed.
> Thanks and regards,
> -Xiao
>
>>> According to PSARC 2008/683, sg3 utilities have to be RBAC
>>> compatible, so two new RBAC profiles introduced here.
>>> Since I need to touch /etc/security/prof_attr and
>>> /etc/security/exec_attr, I have to separate the package into 2 parts,
>>> one for
>>> "root"(for things under /) another is for "usr"(for things under /usr).
>>> I've tested the package SUNWsg3utilsr SUNWsg3utilsu, and seems that
>>> the new profiles will be merged with the existing profiles.
>>> So I think it will not "clobber" the existing files.
>>>
>> Good, I didn't know about the rbac class, I'll look at using it with
>> Lighttpd.
>>
>>
>>> Thanks a lot for your comments,
>>>
>> You're welcome.
>>
>> Amanda
>>
>>
>>> -Xiao
>>>
>>>> I'm new to doing in depth code reviews, but Paul's right we in Sun
>>>> need to do more of them so as to move the process along.
>>>>
>>>> Amanda
>>>>
>>>>
>>>> xiao li - Sun Microsystems - Beijing China wrote:
>>>>
>>>>> Hi Experts,
>>>>> I'm responsible for integrating sg3 utilities into opensolaris.
>>>>> My code change is available at:
>>>>> http://cr.opensolaris.org/~xl222276/sg3utils
>>>>>
>>>>> You comments will be highly appreciated.
>>>>>
>>>>> Thanks and regards,
>>>>> -Xiao
>>>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> sfwnv-discuss mailing list
>>>>> sfwnv-discuss at opensolaris.org
>>>>> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
>>>>>
>>>>>
> _______________________________________________
> sfwnv-discuss mailing list
> sfwnv-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
>
