Hi, See below for some comments from my quick skip through ...
Paul yuan.fan wrote: > > I am porting 'pmtools' to opensolaris, which is a tool managing perl modules. > > Please kindly help me review it. > > http://cr.opensolaris.org/~fanyuan/pmtools === Start of Comments === 1. usr/src/lib/pmtools/Makefile.sfw Change 'env ' to 'env - ' so it doesn't pick up random env variables Do you really need the line ... 49 find $(VER) -type d -exec chmod go+rx {} + if not remove it. Pass VER into the script install-sfw, eg . PKGVERS=$(VER) $(SHELL) ./install-sfw Could you do the lines ... 38 -rm $(ROOT)/usr/perl5/..... 39 -rm $(ROOT)/usr/perl5/..... in the install-sfw script, if so move them there. 2. usr/src/lib/pmtools/install-sfw Pass in PKGVERS= from Makefile.sfw (see (1)) Move the rm's from Makefile.sfw into here (see (1)) Have you validated the script with ... /usr/bin/ksh93 -n install-sfw any warnings are SERIOUS bugs in the code and must be fixed. Does 'make install_vendor' install the files with the same permissions as in prototype_com, if not you need to correct the permissions here (otherwise you will get build check warnings) 3. usr/src/pkgdefs/SUNWpmtools/pkginfo.tmpl On DESC= line, its more common to specify the version as .. DESC="pmtools - Perl module tools (1.10)" 4. usr/src/pkgdefs/SUNWpmtools/prototype_i386 & usr/src/pkgdefs/SUNWpmtools/prototype_sparc Cosmetic: this is not the common form of these files when they are empty - you might want to change that === End of Comments ===== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
