Jim Walker ??: > yuan.fan wrote: > >> Hi All >> >> I am porting 'pmtools' to opensolaris, which is a tool managing perl modules. >> >> Please kindly help me review it. >> >> http://cr.opensolaris.org/~fanyuan/pmtools >> > > You need to re-sync your workspace to the current gate. > > Webrev updated
http://cr.opensolaris.org/~fanyuan/pmtools resync Done. > Please make the CDDL and copyright headers in all files > be consistent with this: (change years to 2009) > http://cr.opensolaris.org/~uniopen/mrtg/usr/src/pkgdefs/SUNWmrtg/pkginfo.tmpl.html > > Done.changed > usr/src/lib/pmtools/install-sfw > - can these lines be removed > 33 # We use install_vendor as make target to ensure that > 34 # the files are installed in vendor_perl directory. > 35 make DESTDIR=${ROOT} INSTALL="/usr/ucb/install -c" install_vendor > - btw: if this stays here the MAKE or CCSMAKE variable should be used > > Done.replaced make with ${MAKE} > usr/src/lib/pmtools/Makefile.sfw > - and the make added here? > 40 MAKE=$(CCSMAKE) \ > 41 /usr/perl5/bin/perl Makefile.PL \ > $(CCSMAKE) DESTDIR=${ROOT} INSTALL="/usr/ucb/install -c" install_vendor) > > It will install files to target dirs,so i placed this function at install-sfw > usr/src/pkgdefs/SUNWpmtools/copyright > - add copyright statements (if any) from the source files like this: > http://cr.opensolaris.org/~jwalker/meld/usr/src/pkgdefs/SUNWmeld/copyright.html > > Done > Otherwise, looks good. > > Cheers, > Jim > > Any comments are appreciate. Thanks very much -yuan.fan
