Hi Yuan,
Please find below some comments
1. Any specific reason for these to be integrated into usr/src/lib ?
tools/utilities are generally added to usr/src/cmd dir.
2. There are few fields missing in METADATA, please follow the rules
specified in the link below :
http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines
3. In Makefile.sfw,
- please use "env -" instead of "env" throughout.
- you could define TARBALL initially in the Makefile.sfw and then
use it later in the targets :
- you could remove "install_h" target if it is not required.
- Pass on the VER to install-sfw. Something like below
PKGVVERS=VER $(SHELL) ./install-sfw
4. Please check all the CDDL headers. The headers need to be consistent.
you could refer to the prortotypes available in below link.
http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/prototypes/
5. It doesn't appear that you are adding sunman-stability to the man
pages. Please check. sunman-stability has to be added to the man pages.
you could refer to below link for more info :
http://ostest.central.sun.com/wiki/index.php/Package_Delivery_Project#3._Develop_Software
Thanks,
Srirama
yuan.fan said the following on Wednesday 17 December 2008 02:16 PM:
> Hi All
>
> I am porting 'pmtools' to opensolaris, which is a tool managing perl modules.
>
> Please kindly help me review it.
>
> http://cr.opensolaris.org/~fanyuan/pmtools
>
> Any comments are appreciated.
>
> thanks
> -yuan.fan
>
> _______________________________________________
> sfwnv-discuss mailing list
> sfwnv-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
>
