Paul, Thank you for the comments very much.
I will make changes accordingly and send the webrev again. Mengwei. Paul Cunningham ??: > Hi Mengwei, > > See my comments below ... > > Paul > > On Tue, 2008-07-29 at 08:56, mengwei wrote: > >> I have complete the code for junit package porting on solaris. >> It is a java Unit testing framework. >> >> Could you please help me review the code? >> >> The webrev can be viewed from: http://cr.opensolaris.org/~mengwei/junit/ >> >> > > === Start of Comments ==== > > 1. usr/src/lib/junit/junit4.4.zip > Version 4.5 is out now so you might want to > think about using that version instead. > > 2. usr/src/lib/junit/install-sfw > I don't think DOCDIR= and SAMPLEDIR= are used so > you could remove these. > > 3. usr/src/pkgdefs/SUNWjunit/depend > I think this looks like the default depend file, so > if you have no other dependencies you could remove this > and use the default one. Just add 'DATAFILE= depend' into > your SUNWjunit/Makefile > > 4. usr/src/pkgdefs/SUNWjunit/Makefile > Is not in your webrev! > > 5. usr/src/pkgdefs/SUNWjunit/prototype_com > Do the file permissions need to be 644, could > they just be 444 ? > > 6. Everything else looks okay to me > > === End of Comments ====== > >
