Paul Cunningham ??:
> Mengwei,
>
> You might want to take on comments from Rowland on Makefile.sfw and
> install-sfw files (but also see his later comments on the sfwnv
> maillist) ...
>
Ok, I will use "env -" to replace "env".
and use $(SHELL) instead of $(SH)
and use "source" instead of "."
> Roland Mainz wrote:
>
>> 1. AFAIK these things may be nice (most of these item are very generic
>> things which are "usual suspects" for build problems in the tree):
>> - Please use "env - ..." and not "env ..." in the Makefiles to make sure
>> "configure"&&"make" only see the env variables they should really get
>> (and not pick-up any random env variable)
>> - Please use either $(SHELL) or /usr/bin/bash for "configure" calls (so
>> we know which one is used and "configure" doesn't pick one itself)
>>
>
>
>> - Please use /usr/bin/ksh93 or /usr/bin/bash for install-sfw* and add a
>> $ set -o errexit # at the beginning and replace ".
>> ${SRC}/tools/install.subr" with "source ${SRC}/tools/install.subr" (the
>> idea is to catch failures in the script and abort it at that point,
>> right now the script will just continue)
>>
>
>
> Also in your usr/src/lib/junit/sunman/junit.3.sunman it should probably
> say 'by Sun Microsystems to'. And is Interface 'Stability External'
> correct?
>
I am not sure.
I copy the External(New value is Volatile) from ant man page.
but actually I think the interface is stable.
What do you suggest for this attribute?
> The rest seems okay to me
>
> Paul
>
>
>
> mengwei wrote:
>
>> Hi,
>>
>> I have update the junit package according to your review comments.
>>
>> http://cr.opensolaris.org/~mengwei/junit/
>>
>> The changes are:
>>
>> 1. Update junit from 4.4 to 4.5.
>>
>> 2. Add build.xml, build the binary jar file from the source.
>>
>> 3. Add man page
>>
>> 4. Use "DATAFILE= depend" in SUNWjunit/Makefile instead of a depend file
>>
>> 5. change file permission from 644 to 444.
>>
>>
>> Please review the code again,
>>
>>
>> thank you very much.
>> Mengwei.
>>
>>
>>
>
>
