Mengwei, Here are some comments:
Can you file an RFE for this and include the bug information in the webrev for each file? You need to add a man page for junit. Here is an example (it's out-of-date): http://linux.com.hk/penguin/man/1/junit.html Here's some man page source code: http://cr.opensolaris.org/~jwalker/meld/ You may want to consider dividing junit into two packages like they do for debian (junit 3.8.2): http://packages.debian.org/sid/all/junit/filelist http://packages.debian.org/sid/all/junit-doc/filelist I don't see the source code being delivered in these packages, so for now, I wouldn't deliver the source for the Junit jar file. usr/src/lib/junit/install-sfw - This: 20 # CDDL HEADER END 21 # 22 # Copyright 2008 Sun Microsystems, Inc. All rights reserved. 23 # Use is subject to license terms. 24 # 25 # pragma ident "@(#)install-sfw 1.1 08/07/29 SMI" 26 # - Should be: 20 # CDDL HEADER END 21 # 22 23 # 24 # Copyright 2008 Sun Microsystems, Inc. All rights reserved. 25 # Use is subject to license terms. 26 # 27 # pragma ident "@(#)install-sfw 1.1 08/07/29 SMI" 28 # 35 36 - removed extra blank lines usr/src/pkgdefs/SUNWjunit/prototype_sparc usr/src/pkgdefs/SUNWjunit/prototype_i386 usr/src/pkgdefs/SUNWjunit/prototype_com usr/src/pkgdefs/SUNWjunit/pkginfo.tmpl usr/src/lib/junit/Makefile.sfw 1 # - remove extra blank comment line. - This: 20 # CDDL HEADER END 21 # 22 # Copyright 2008 Sun Microsystems, Inc. All rights reserved. 23 # Use is subject to license terms. 24 # 25 # pragma ident "@(#)Makefile.sfw 1.1 08/07/29 SMI" 26 # - Should be: 20 # CDDL HEADER END 21 # 22 23 # 24 # Copyright 2008 Sun Microsystems, Inc. All rights reserved. 25 # Use is subject to license terms. 26 # 27 # pragma ident "@(#)install-sfw 1.1 08/07/29 SMI" 28 # 29 usr/src/lib/junit/Makefile.sfw 43 - remove extra blank line usr/src/lib/junit/METADATA - add the following before COMMENTS line BUGTRAQ: solaris/utility/junit SUPPORT: Community I don't know if usr/share/lib/java/junit is the best location. Your ARC sponsor can help here. Cheers, Jim mengwei wrote: > Dear Sir/Madam, > > I have complete the code for junit package porting on solaris. > It is a java Unit testing framework. > > Could you please help me review the code? > > The webrev can be viewed from: http://cr.opensolaris.org/~mengwei/junit/ > > Thank you! > > Mengwei
