Venky, See below for my comments from my quick skip through ...
Paul Venky wrote: > I'm porting Privoxy[1] to SFW. Would appreciate a code review of my > changes. This is my first SFW integration, so it is possible there > are some beginner's mistakes. > > The webrev is here: > http://cr.opensolaris.org/~venkytv/privoxy/ > > References: > [1] Privoxy is a non-caching web proxy with filtering capabilities. > http://www.privoxy.org/ ==== Start of Comments ==== 1. usr/src/cmd/privoxy/METADATA You need to add all the missing fields - see other pkg METADATA files for examples. 2. usr/src/cmd/privoxy/Makefile.sfw You could use the default '--prefix=' (line 53) from Makefile.master now, eg. configure $(CONFIGURE_OPTIONS). See other recent package integrations for examples. Use the default '/etc' value defined in Makefile.master. Do you need to explicitly configure the var and man dirs for clarity? Again using the values from Makefile.master Do you need to run 'autoconf', could you have just used the 'configure' that came with the src? 3. usr/src/cmd/privoxy/Solaris/http-privoxy Does this need a 'stop' case for completeness? 4. usr/src/cmd/privoxy/install-privoxy Is 'LOGDIR=${PREFIX}/var/log/privoxy' correct, eg. /usr/var? Is it used, if not remove it. 5. SUNWprivoxyu Have you run the dependencies checker script on your pkg to ensure it doesn't really have any dependencies? Doesn't it depend on SUNWprivoxyr ? 6. Everything else looks okay to me. ==== End of Comments ======
