Thanks, Pradhap! On Wed, Aug 13, 2008 at 01:10:03PM +0530, Pradhap Devarajan wrote: > Quick glance... > > *) Update Metadata file with somemore additional data > eg) > http://cr.opensolaris.org/~pd155743/librsync/raw_files/new/usr/src/lib/librsync/METADATA
Will do. > *) Use $CONFIGURE_OPTIONS instead of hardcoding "/usr" for configure Right. > *) depend files are missing for packages Since there were no changes from the default ../common_files/depend, I was using the "DATAFILES" approach in the Makefile. However, it looks like I'll need to put in a dependency on SUNWprivoxyr for SUNWprivoxyu, so I'll be adding a depend file there. Thanks for the quick review! Cheers, Venky. > > thanks, > Pradhap.D > > Venky wrote: > >> I'm porting Privoxy[1] to SFW. Would appreciate a code review of my >> changes. This is my first SFW integration, so it is possible there >> are some beginner's mistakes. >> >> The webrev is here: >> http://cr.opensolaris.org/~venkytv/privoxy/ >> >> Thanks, >> Venky. >> >> References: >> [1] Privoxy is a non-caching web proxy with filtering capabilities. >> http://www.privoxy.org/ >> _______________________________________________ >> sfwnv-discuss mailing list >> sfwnv-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss >> >> > > -- > MTS - OP/N1 RPE > Sun Microsystems (I) Pvt Ltd > Bangalore > Extn : x87103 > Direct : +91 80 56937103 > Mob: +91 98802 95937 > -- One hundred thousand lemmings can't be wrong.
