Forgot to mention. The new webrev is here: http://cr.opensolaris.org/~venkytv/privoxy-20080819.1/
Thanks, Venky. On Tue, Aug 19, 2008 at 08:15:07PM +0530, Venky wrote: > You are right. I had messed this up. > > Have fixed it. SUNWprivoxyu depends on SUNWprivoxyr and SUNWpcre > now and SUNWprivoxyr uses the default "depend". > > Thanks for the quick review, Paul. > > Cheers, > Venky. > > On Tue, Aug 19, 2008 at 03:18:57PM +0100, Paul Cunningham wrote: > > Venky, > > > > This looks okay to me except for the SUNW package dependency stuff, but > > I may be misunderstanding what you are doing with it .... > > > > SUNWprivoxyr has a 'depend' file but SUNWprivoxyu doesn't. > > > > SUNWprivoxyr depends on SUNWprivoxyu (by the way the comment is wrong > > there) ? And there is also a dependency on SUNWpcre. > > > > Shouldn't SUNWprivoxyr just have the default 'depend'. And SUNWprivoxyu > > depend on SUNWprivoxyr & SUNWpcre (and default stuff)? > > > > Paul > > > > > > Venky wrote: > >> Have uploaded the updated webrev incorporating the comments here: > >> http://cr.opensolaris.org/~venkytv/privoxy-20080819/ > >> > >> The webrev does not include the source tarball since webrev generates > >> a bunch of errors when it encounters binary files. It has been > >> checked into the workspace though. > >> > >>> Do you need to run 'autoconf', could you have just > >>> used the 'configure' that came with the src? > >> > >> I checked this again. The source does not include the configure > >> script. > > > > -- > > ---------------------------------------------------------------------- > > Paul Cunningham > > Software Engineer > > Tadpole Computer Products > > -- > One hundred thousand lemmings can't be wrong. -- One hundred thousand lemmings can't be wrong.
